Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hiop interface due to the latest changes in hiop #30

Closed
wants to merge 2 commits into from

Conversation

nychiang
Copy link
Collaborator

@nychiang nychiang commented Oct 5, 2023

update hiop interface due to the latest developments in hiop

CLOSE #28

@cameronrutherford
Copy link
Contributor

cameronrutherford commented Oct 11, 2023

I think we want #20 merged before this, and perhaps need to resolve #10 for Ascent in CI to make this trivial to re-build and test. Thanks for the fix @nychiang, and hopefully we can merge this soon once we wrap up P6 and reporting activities.

We are also gearing up for a release soon, but might delay in favor of debugging this and getting compatibility back with [email protected] working...

cc @abhyshr

@cameronrutherford
Copy link
Contributor

@nychiang I might just have this re-target #20, and have that branch do the re-builds automatically :)

@cameronrutherford
Copy link
Contributor

Included changes in #20. Will close issue in that PR. Thanks @nychiang

p.s. hopefully whenever hiop@develop has changes, we can use some pipelines to make a PR into exago and verify it doesn't break our build/tests. I will open a PR with this next quarter if I can find time

@cameronrutherford
Copy link
Contributor

Since this change isn't necessary to build with 1.0.0, we are going to pin that version for our release, and then re-visit hiop@develop capability.

@jaelynlitz
Copy link
Contributor

Is this ready to merge?

@cameronrutherford
Copy link
Contributor

Is this ready to merge?

Pipelines are failing, so no

@jaelynlitz
Copy link
Contributor

closing as this was wrapped into #84

@jaelynlitz jaelynlitz closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExaGO builds fail with [email protected]
3 participants