Skip to content
CI

fix(marimekko): use readonly arrays for props as the library does not modify them #2280

Sign in to view logs

fix(marimekko): use readonly arrays for props as the library does not modify them

fix(marimekko): use readonly arrays for props as the library does not modify them #2280

Triggered via pull request December 24, 2023 23:05
@pcorpetpcorpet
opened #2493
pcorpet:readonly-marimekko
Status Failure
Total duration 1m 36s
Artifacts –

ci.yml

on: pull_request
build
1m 19s
build
end-to-end-tests
1m 26s
end-to-end-tests
Fit to window
Zoom out
Zoom in

Annotations

8 errors
build: packages/marimekko/src/hooks.ts#L234
Property 'push' does not exist on type 'readonly DimensionDatum<RawDatum>[]'.
build: packages/marimekko/src/Marimekko.tsx#L115
Type 'readonly number[] | undefined' is not assignable to type 'TicksSpec<ScaleValue> | undefined'.
build: packages/marimekko/src/Marimekko.tsx#L116
Type 'readonly number[] | undefined' is not assignable to type 'TicksSpec<ScaleValue> | undefined'.
build
Process completed with exit code 2.
end-to-end-tests: packages/marimekko/src/hooks.ts#L234
Property 'push' does not exist on type 'readonly DimensionDatum<RawDatum>[]'.
end-to-end-tests: packages/marimekko/src/Marimekko.tsx#L115
Type 'readonly number[] | undefined' is not assignable to type 'TicksSpec<ScaleValue> | undefined'.
end-to-end-tests: packages/marimekko/src/Marimekko.tsx#L116
Type 'readonly number[] | undefined' is not assignable to type 'TicksSpec<ScaleValue> | undefined'.
end-to-end-tests
Process completed with exit code 2.