-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manhattan improve app #67
Conversation
@@ -27,42 +27,76 @@ def layout(): | |||
id='mhp-page-content', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly moving divs around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the sliders I noticed that the graph did not actually update after the 1st or 2nd iteration. I think this is because of Heroku (mem error
), and would recommend testing your application on DDS to make sure it's working the way it should!
In terms of style I would wrap the intro
and sliders
in a div
and set a width
so they are flush with one another. It would also look nice to put a border around the intro
and controls
just like your Volcano application. If you could center the graph title and x-axis that would be also great.
Volcano application I'm referring to: https://dash-bio-test-pr-65.herokuapp.com/dash-bio/volcano-plot
|
@matthewchan15 the title is centered on the graph area, I prefer to leave it that way. |
Looks good! 💃 |
Dash Bio pull request
-didn't address the part of adding more control to change the color, width.
DDS Deployment
developers
user credentials from a dash-bio team member.git pull
).git remote -v
, make sure you have the dash-bio one:https://dash-gallery.plotly.host/GIT/dash-bio
.git remote add dash-bio https://dash-gallery.plotly.host/GIT/dash-bio
.developers
user credentials, have them ready.git push dash-bio master
.DDS Deployment Debugging
git push dash-bio master
you may encounter the following issue:This may be because the
git
credentials are saved on theclient-side
. In order to solve this, do the following:Windows
OS X