Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manhattan improve app #67

Merged
merged 6 commits into from
Dec 6, 2018
Merged

Manhattan improve app #67

merged 6 commits into from
Dec 6, 2018

Conversation

Bachibouzouk
Copy link
Contributor

@Bachibouzouk Bachibouzouk commented Dec 3, 2018

Dash Bio pull request

DDS Deployment

  • Get the developers user credentials from a dash-bio team member.
  • Checkout the master branch of the dash-bio repository, make sure you have the latest master (git pull).
  • Check remotes associated to your repository: git remote -v, make sure you have the dash-bio one: https://dash-gallery.plotly.host/GIT/dash-bio.
  • If you don't have the dash-bio remote add it with https, ssh will not work: git remote add dash-bio https://dash-gallery.plotly.host/GIT/dash-bio.
  • You will be asked to enter the developers user credentials, have them ready.
  • Push local master to the dds dash-bio master: git push dash-bio master.

DDS Deployment Debugging

  • If running git push dash-bio master you may encounter the following issue:
remote: User <username> does not have permissions to run git-hook on dash-bio, or dash-bio does not exist
remote: Access denied
To https://dash-gallery.plotly.host/GIT/dash-bio
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'https://dash-gallery.plotly.host/GIT/dash-bio'

This may be because the git credentials are saved on the client-side. In order to solve this, do the following:

Windows

Go to: Control Panel -> User Accounts -> Manage your credentials -> Windows Credentials -> Under Generic Credentials find: git:https://dash-gallery.plotly.host -> Remove credential OR edit username/password to provided account.

OS X

Go to: Keychain Access -> Search for dash-gallery.plotly.host -> Change "Account" to "developers" -> Click on "show password" -> Change the password to the one provided -> Click "Save Changes". 

@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-67 December 3, 2018 13:14 Inactive
@@ -27,42 +27,76 @@ def layout():
id='mhp-page-content',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly moving divs around

@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-67 December 3, 2018 20:11 Inactive
@mtwichan mtwichan temporarily deployed to dash-bio-test-pr-67 December 4, 2018 17:43 Inactive
Copy link
Contributor

@mtwichan mtwichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bachibouzouk

When using the sliders I noticed that the graph did not actually update after the 1st or 2nd iteration. I think this is because of Heroku (mem error), and would recommend testing your application on DDS to make sure it's working the way it should!

In terms of style I would wrap the intro and sliders in a div and set a width so they are flush with one another. It would also look nice to put a border around the intro and controls just like your Volcano application. If you could center the graph title and x-axis that would be also great.

Volcano application I'm referring to: https://dash-bio-test-pr-65.herokuapp.com/dash-bio/volcano-plot

@Bachibouzouk
Copy link
Contributor Author

testing your application on DDS to make sure it's working the way it should
@matthewchan15 it does work on DDS :) -> https://dash-gallery.plotly.host/dash-bio/manhattan-plot

@Bachibouzouk
Copy link
Contributor Author

If you could center the graph title and x-axis that would be also great.

@matthewchan15 the title is centered on the graph area, I prefer to leave it that way.

@mtwichan
Copy link
Contributor

mtwichan commented Dec 5, 2018

Looks good! 💃

@Bachibouzouk Bachibouzouk merged commit b6c9614 into master Dec 6, 2018
@Bachibouzouk Bachibouzouk deleted the manhattan_improve_app branch December 6, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Manhattanplot
2 participants