Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork/refactor and testing #106

Merged

Conversation

aarijimam
Copy link
Contributor

@aarijimam aarijimam commented Oct 25, 2024

Refactor to DI

Function Implementation Checklist in Revamped DI-Based Architecture

PlayroomKit:

For:

  • Local mock mode
  • BrowserBridge mock mode
  • Build

Player

  • GetProfile(): Retrieves the profile of the current player.
  • GetState(string key): T: Fetches the state associated with the specified key.
  • SetState(string key, T value, bool reliable = false): Sets the state for the specified key with an optional reliability flag.
  • WaitForState(stateKey: string, onStateSetCallback): Waits for a specific state to be set and invokes the callback when it is ready.
  • Kick(): Removes the player from the game or session.
  • OnQuit(callback): Registers a callback to be invoked when the player quits.
  • MatchmakingOptions: Configures options related to matchmaking for the player.
  • RpcRegister(string name, Action<string, string> rpcRegisterCallback, string onResponseReturn = null): Registers a remote procedure call (RPC) with a callback, optionally specifying a return response.
  • RpcCall(string name, object data, RpcMode mode, Action callbackOnResponse): Calls an RPC with specified data and mode, and triggers a callback upon response.

For:

  • Local mock mode
  • BrowserBridge mock mode
  • Build

@momintlh momintlh mentioned this pull request Oct 30, 2024
@momintlh
Copy link
Collaborator

Test the new demo scene in build mode to see if anything is broken, then I think we are ready for merge here!

Copy link
Collaborator

@SaadBazaz SaadBazaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the dependencies folder really needed in the repo?

@momintlh momintlh merged commit bac4a1d into playroomkit:refactor-and-testing Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants