Add tests for FE date calculations, fix niggles with site context #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
dashboard-date-calculations-issue
branch
from
11ca19b
to
efb4ed6
Compare
apata
changed the title
apata
force-pushed
the
dashboard-date-calculations-issue
branch
6 times, most recently
from
4f5c892
to
af7dfa4
Compare
apata
changed the title
apata
force-pushed
the
dashboard-date-calculations-issue
branch
from
af7dfa4
to
272710d
Compare
|
RobertJoonas
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hypothesis: To correctly perform any date calculations, one needs to know the timezone: current offset is not enough, since the calculation may span the time when the offset changes.
However, when needing only date level precision, assuming the BE returns the offset as expected, I couldn't find any issues.
(The first commit seemed to verify the hypothesis, but it had an incorrect expectation.)