Implement UI to edit existing funnels

[aerosol]

Changes

This PR adds the option to edit exiting funnels and btw fixes the UI CSS quirks as a result of improper tailwind build configuration. The modal now displays nicer.

Tests

• Automated tests have been added
• This PR does not require tests

Changelog

• Entry has been added to changelog
• This PR does not make a user-facing change

Documentation

• Docs have been updated
• This change does not need a documentation update

Dark mode

• The UI has been tested both in dark and light mode
• This PR does not change the UI

[github-actions]

Preview environment👷🏼‍♀️🏗️
PR-4369

[apata]

Great job! I really appreciate the tests here.

I have it checked out locally, and I'm able to edit funnels and in the edit modal add steps to a funnel.

However, in the preview environment at https://pr-4369.review.plausible.io/pr4340.plausible.io/settings/funnels, in the modal, I'm not able add extra goals to the funnel.

Which is the expected behaviour? Am I reading it correctly that the tests don't cover adding a goal?

[aerosol]

@apata definitely unexpected, can you tell me how to reproduce?

[apata]

@apata definitely unexpected, can you tell me how to reproduce?

Log in to a company in the https://pr-4369.review.plausible.io/ environment. Accept the invite to my site https://pr-4369.review.plausible.io/pr4340.plausible.io. Then try to edit the existing funnel.

[apata]

@apata definitely unexpected, can you tell me how to reproduce?

Ah, figured it out. My bad!

I only had two goals in total and two steps in the funnel. As soon as I added a third goal, the Edit funnel modal offered me the choice to add another step to the existing funnel.

[aerosol]

Thanks for looking @apata, appreciate it!

[apata]

Anytime!

Actually, I played around some more, and in trying to reorder my three step funnel, I was quickly able to reach an unexpected UI state.

I've got two revenue goals and one non-revenue goal yay (USD), yay two (USD), yay three but it seems as if the UI sometimes treats the revenue goal without the revenue appendix yay two as a separate valid option.

It's not a big deal because it's still possible to reach a valid reordered funnel. That's the basis of my approval: massive improvement over not being able to edit at all.

[aerosol]

I've got two revenue goals and one non-revenue goal yay (USD), yay two (USD), yay three but it seems as if the UI sometimes treats the revenue goal without the revenue appendix yay two as a separate valid option.

Not sure what you mean @apata, would you mind rephrasing this? What's a "revenue goal without the revenue appendix"? If you mean a Custom Event, then it's a separate goal.

[aerosol]

Hmm I think I see what you mean, when adding a goal it appears as an option, without the currency.

[aerosol]

Should be fixed by 8090687

[apata]

Hehe, so fast! Well done, that was exactly it. From my side, the approval intensifies.