Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 support for attachment uploads #938

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

haiquang9994
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2024

CLA assistant check
All committers have signed the CLA.

@meltyshev
Copy link
Member

Hi! Thanks for the PR 🙏
I’ll try to check everything today/tomorrow and accept it.

@meltyshev
Copy link
Member

I've tested everything, and it works fine, but we’d like to make a few changes before releasing this:

  • Upgrade to a new version of the SDK, as the current one will no longer be supported in 2025.
  • Establish an S3 connection in the startup hook to enable connection reuse (probably should improve performance).
  • Avoid storing the full address in the attachment table and construct the address dynamically. If the S3 environment variables are specified, always default to using S3, rather than relying on the type field of an attachment.
  • Ensure attachments aren't publicly accessible and always re-stream them through the Planka server (should have a valid accessToken and permissions to see the attachment).

We're accepting it in the current state, and I'll fix the mentioned points in the next commits. Thank you!

@meltyshev meltyshev merged commit 950a070 into plankanban:master Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants