Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor attribute filtering in PlexObject class #1341

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Refactor attribute filtering in PlexObject class #1341

merged 2 commits into from
Feb 17, 2024

Conversation

Dr-Blank
Copy link
Contributor

@Dr-Blank Dr-Blank commented Jan 16, 2024 •
edited
Loading

Description

ref: #1302 (comment)

The changes optimize the code by using the filter function instead of a list comprehension.

Type of change

Please delete options that are not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@Dr-Blank
Refactor attribute filtering in PlexObject class
d3d81f7 
- minor performance imporvement
JonnyWong16
JonnyWong16 reviewed Feb 4, 2024
View reviewed changes
plexapi/base.py Outdated Show resolved Hide resolved
@Dr-Blank @JonnyWong16
Update plexapi/base.py
244df26 
Co-authored-by: JonnyWong16 <[email protected]>
@JonnyWong16 JonnyWong16 merged commit 41f6b9c into pkkid:master Feb 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonnyWong16 JonnyWong16 JonnyWong16 approved these changes

Assignees
No one assigned
Labels
non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr-Blank @JonnyWong16