Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official github-pages action to deploy #8

Closed
wants to merge 1 commit into from
Closed

Conversation

vanbroup
Copy link
Contributor

@vanbroup vanbroup commented Jul 1, 2024

No description provided.

@vanbroup vanbroup requested a review from 3keyroman July 1, 2024 09:22
@3keyroman
Copy link
Collaborator

@vanbroup is this going to be deployed in develop folder in gh-pagesbranch?

This is the folder where we have the current base of the web component.
When we want to release, there is action https://github.com/pkic/self-assessment/blob/main/.github/workflows/release.yml that should deploy the released web component into folder with the tag name.

Is this going to work with this change?

@vanbroup
Copy link
Contributor Author

vanbroup commented Jul 1, 2024

The preview function is indeed still in preview and I don't think we can set a target directory.

Maybe we should leave it as is for now and change when GitHub finally releases the preview functionallity.

@vanbroup vanbroup closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants