Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PDF data and layout #13

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Improve PDF data and layout #13

merged 2 commits into from
Jul 6, 2024

Conversation

3keyroman
Copy link
Collaborator

@3keyroman 3keyroman commented Jul 3, 2024 •
edited
Loading

  • include first page with PKIC logo
  • add model version to summary
  • add report date to summary
  • add link to the assessment
  • remove header and footer from first page

Close #3

@3keyroman
Improve PDF data and layout
3b84c6e 
- include first page with PKIC logo
- add model version to summary
- add report date to summary
- add link to the assessment
- remove header and footer from first page
@3keyroman 3keyroman requested a review from vanbroup July 3, 2024 14:38
@3keyroman
Copy link
Collaborator Author

I was not able to find a way how to get SVG instead of PNG or WEBP... it seems that the library does not support it yet.
TOC should be included as part of the bookmarks.

@vanbroup
Copy link
Contributor

vanbroup commented Jul 6, 2024

Is there a build preview?

The SVG images that you have embedded in the code are currently not used?

@3keyroman
Copy link
Collaborator Author

Is there a build preview?

The SVG images that you have embedded in the code are currently not used?

All except the chart is SVG. I am not able to figure out how to make SVG from the canvas element.
Here is the sample improved generated PDF.
PKIMM-self-assessment-report-improved.pdf

vanbroup
vanbroup reviewed Jul 6, 2024
View reviewed changes
Copy link
Contributor

@vanbroup vanbroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting really nice!

I have made some suggestions with further improvements, sorry that I haven’t been able to contribute any of these suggestions myself yet.

src/utils/pdfGenerator.tsx Outdated Show resolved Hide resolved
src/utils/pdfGenerator.tsx Outdated Show resolved Hide resolved
src/utils/pdfGenerator.tsx Show resolved Hide resolved
@vanbroup
Copy link
Contributor

vanbroup commented Jul 6, 2024

Should we add an image with the logos of the PKI sponsors on the about page?

@3keyroman
Copy link
Collaborator Author

Anything can be done...
See updated report: PKIMM-self-assessment-report-0.0.1.pdf

@vanbroup vanbroup merged commit a1a5f56 into main Jul 6, 2024
4 checks passed
@vanbroup vanbroup deleted the improve-pdf-layout branch July 6, 2024 16:17
@3keyroman
Copy link
Collaborator Author

Should we add an image with the logos of the PKI sponsors on the about page?

In my opinion, it would be best to keep the reference to PKIC without including the logos of sponsors. The section about sponsors is subject to change, necessitating updates each time. Although this process can be automated, including the logos in the report might look overpaid and could be disruptive for users who wish to share the report. I would keep it clean.

Anyone interested can easily access the PKIC link to view the current sponsors and other information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanbroup vanbroup vanbroup left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements on PDF generated report
2 participants
@3keyroman @vanbroup