Accept Throwable for onRejected and expand return type for wait() #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
wait()
to handle the possiblevoid
andnull
return values based on the method's description.\Throwable
interface instead of\Exception
inonRejected
callable parameter typeChecklist
To Do
wait()
e.g.@return ($unwrap is true ? T : null|void)
. This would eliminate further PHPStan failures for dependent libs, however this syntax requires PHPStan^1.6.0
. Would this be a better approach? At the moment, usingT|null|void
could cause further PHPStan failures for dependent libs. Would these further failures be considered a BC break?