Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concludes the test of using a constrained-normal monad wrapper over Probability.
>>=
seems to shave off a couple seconds off runtime. 20s to 17s, retains the 16G allocations.An interesting direction could be to put a
Set (p,a)
instead of[(p,a)]
, but it'd probably only save a tiny amount (by avoiding the Data.Map.toList/Data.Map.fromList on every bind).Note that these results are in GHCi, because we're interested in complexity more than GHC's optimizations. Here's compiled with -O:
Original
Constrained normal
norm on rhs