Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Azure AD to Entra ID #845

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

JeffreyThiessen
Copy link
Member

@JeffreyThiessen JeffreyThiessen commented Nov 19, 2024

What does this PR do and why?

_Describe in detail what your merge request does and why.
Fixes #840

Azure AD is being deprecated in favour of Entra ID. They function identically but with a different name.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Clean you db ./scripts/clean_dev.sh
  2. edit config/authentication/auth_config.yml to add entra_id to development: -> omniauth_providers:
  3. edit your credentials file

EDITOR="vim --nofork" bin/rails credentials:edit --environment development

Add the following fields. Message me directly for the secret credentials.

entra_id:
  client_id: secret
  client_secret: secret
  tenant_id: secret
  1. run irida next
  2. click the sign in button for Entra ID
  3. Go to http://localhost:3000/-/profile and verify that a user account has been created for you with the relevant provider info.
    image

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Copy link

Code Metrics Report

Coverage Test Execution Time
93.2% 9m31s

Code coverage of files in pull request scope (13.4%)

Files Coverage
app/controllers/users/omniauth_callbacks_controller.rb 85.0%
app/models/user.rb 0.0%

Reported by octocov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deps: Replace omniauth-azure-activedirectory-v2 with omniauth-entra-id
1 participant