Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table Component and update to profiles PAT table #836

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Nov 5, 2024

What does this PR do and why?

This PR adds the DataTableComponent which acts as the shell for our table components and will eventually be implemented into all our tables.

To start, the PersonalAccessTokens table has been updated to use the DataTableComponent

Screenshots or screen recordings

image

How to set up and validate locally

  1. Navigate to the access tokens page via User Settings > Access Tokens
  2. Verify the access tokens table lists the proper data as expected
  3. Verify Revoke works as expected
  4. Additional user feedback (flash messages) has been added to this page. Test the following and ensure the proper messages are displayed:
  • Create access token successfully
  • Create access token failure with no scopes selected
  • Revoke token success
  1. Verify empty table state when no personal access tokens

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ChrisHuynh333 ChrisHuynh333 self-assigned this Nov 5, 2024
@ChrisHuynh333 ChrisHuynh333 marked this pull request as ready for review November 5, 2024 21:17
@ChrisHuynh333 ChrisHuynh333 added the ready for review Pull request is ready for review label Nov 5, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants