Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sloped/transform shape with non-identity transformation #1371

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Qrrbrbirlbel
Copy link
Contributor

This applies the fixes of @thinbold and @muzimuzhi also to curves and arc while not globalize xc/yc for the line function.

In my opinion, this is not a breaking change because the previous behavior was never the intended way.

This is a redo of #1287 because I'm fighting with GitHub.

Motivation for this change

Fixes #1058

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

Qrrbrbirlbel and others added 9 commits October 21, 2023 16:56
This applies the fixes of thinbold and muzimuzhi also to curves and lines while not globalize xc/yc for the line.

Co-Authored-By: Yukai Chou <[email protected]>
Co-Authored-By: Thin Bold <[email protected]>
Co-Authored-By: Yukai Chou <[email protected]>
Co-Authored-By: Thin Bold <[email protected]>
This applies the fixes of thinbold and muzimuzhi also to curves and lines while not globalize xc/yc for the line.

Co-Authored-By: Yukai Chou <[email protected]>
Co-Authored-By: Thin Bold <[email protected]>
Signed-off-by: Qrrbrbirlbel <[email protected]>
Co-Authored-By: Yukai Chou <[email protected]>
Co-Authored-By: Thin Bold <[email protected]>
Signed-off-by: Qrrbrbirlbel <[email protected]>
Signed-off-by: Qrrbrbirlbel <[email protected]>

Signoff

Signed-off-by: Qrrbrbirlbel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

sloped should consider the current transformation
1 participant