-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing inclusion of libraries in graphdrawing examples #1335
base: master
Are you sure you want to change the base?
Conversation
of the examples at https://tikz.dev/gd-trees Signed-off-by: Hanson Char <[email protected]>
pgf-tikz#1335 Signed-off-by: Hanson Char <[email protected]>
pgf-tikz#1335 Signed-off-by: Hanson Char <[email protected]>
Signed-off-by: Hanson Char <[email protected]>
discussion at pgf-tikz#1335 Signed-off-by: Hanson Char <[email protected]>
discussion at pgf-tikz#1335 Signed-off-by: Hanson Char <[email protected]>
Signed-off-by: Hanson Char <[email protected]>
Sorry @muzimuzhi, took a bit longer, but now I have shed some light again into this issue. @hansonchar is right that there are missing occurrences of needed libraries. All of that started in issue #640. But at some point a question arose which (unfortunately) never was answered. So the work didn't continue. When I remember correctly, the most important point why the work didn't continue was, that the There are much more examples lacking libraries. See e.g. PR #883 which isn't merged yet (reason unknown anymore). And there is also Mo-Gul@af40f01 which could be cherry-picked. And it is very likely that there will be missing even more. If only Please also note that the "extractor scripts" (Bash version and PowerShell version) need to be adapted to work after the "flattening of the file structure" ... |
This PR is tangentially related to #1339 I think we can make small, incremental changes iteratively, instead of blocking these changes (that absolutely improve the pgfmanual) on the basis of the lack of a perfect solution. What do you think? In any case, I'll try to take a look at the extractor script problems later on. One step/issue at a time. |
Signed-off-by: Hanson Char <[email protected]>
As an interesting trivia, I think I've found where the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
About "Kellerman" vs. "Kellermann": On that you have to agree with the others.
Motivation for this change
Some of the examples at https://tikz.dev/gd-trees and https://tikz.dev/gd-usage-tikz don't currently compile with
lualatex
.Checklist
Testing
Changes tested successfully on Apple M2.
Prior to this change, the example code would fail with the following log message:
Local building of
build/doc/pgfmanual.pdf