fix: allow XOR and XNOR gates to have more than 2 inputs #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There have been several requests for XOR and XNOR gates to allow more than 2 inputs [#376] [1] [2]. This PR fixes that and updates the docs.
As far as I can see, the previous concern was a potentially ambiguous IEC symbol [ = 1 ]. However, extended gates are widely interpreted to represent the cascade of such binary operations and there is clear demand to display such symbols (from me too).
As a weird quirk, ICE XNOR gates have always been able to accept more than 2 inputs - in opposition to the docs.
Fixes #376
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: