Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Postgres image if running on CI #35

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

andyundso
Copy link
Member

We run into space problem on CI when running the tests for newer Postgres version with the new Debian image. This PR amends the tests to delete the Postgres images when running on CI.

@andyundso andyundso marked this pull request as ready for review July 12, 2024 16:04
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, lets try it out. 😄

@justinclift justinclift merged commit 71f438a into main Jul 12, 2024
22 checks passed
@justinclift justinclift deleted the clear-images-after-each-test branch July 12, 2024 22:13
@justinclift
Copy link
Member

justinclift commented Jul 13, 2024

Awesome, looks like it worked!

I'll update the README here about it in a few hours, and the similar info on the Docker repo as well. 😄


This is really good stuff @andyundso. Pretty sure lots of people who weren't previously able to auto-upgrade their databases now can do so. 😄

@justinclift
Copy link
Member

Uh oh, it looks like we're still running out of disk space:

https://github.com/pgautoupgrade/docker-pgautoupgrade/actions/runs/10094729660

image

Anyone have ideas on what else we can do to get this working?

@andyundso
Copy link
Member Author

it looks like the runner ran out of disk space when trying to build / push the final image version. not sure if we can delete all these Redash images / containers / volumes after the test to solve the issue.

@justinclift
Copy link
Member

k. We'll probably need to put some time aside to experiment. Alternatively, we might need use self-hosted runners for a while (hopefully short term) as with those we can allocate as much disk space as we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants