Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node community's library #76

Merged
merged 1 commit into from
Dec 28, 2020
Merged

update node community's library #76

merged 1 commit into from
Dec 28, 2020

Conversation

pyramation
Copy link
Contributor

Thank you for the amazing library! I appreciated getting coffee with you in SF a few years back... hope to catch up again!

I've updated to the link to the nodejs parser, as the the linked library hasn't been maintained. The author has been m.i.a. since January 2018

Comparisons just in case you are curious

Activity

summer of 2018 was last commit of real substance, although arguable 2017 and earlier was any real work.

  • pgsql-parser is 219 commits ahead and very actively developed.

Screen Shot 2020-11-10 at 6 59 17 PM

Functionality

  • pgsql-parser has implemented 95 AST nodes vs only 35 for the original library

pgsql-parser

Maintenence

zhm/pg-query-parser#8
zhm/pg-query-parser#17
zhm/pg-query-parser#13

Still no response from owner.

numerous issues solved in new repo, but left open with no comms in zhm's:
zhm/pg-query-parser#8
zhm/pg-query-parser#17
zhm/pg-query-parser#13

@pyramation pyramation changed the title update node communities library update node community's library Nov 11, 2020
@lfittl
Copy link
Member

lfittl commented Dec 28, 2020

@pyramation Thanks for the detailed update - I think it makes sense to adjust the Node.js library to reference your newer version instead.

@lfittl lfittl merged commit a62dbce into pganalyze:10-latest Dec 28, 2020
lfittl pushed a commit that referenced this pull request Jan 4, 2021
The original Node.js library is no longer actively maintained, adjust reference to a fork thats maintained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants