Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding important graph metrics in pgRouting #2543

Closed
wants to merge 1 commit into from

Conversation

sbdtu5498
Copy link
Member

Changes proposed in this pull request:

  • These functions are based on my work in the past.
  • I have added two more signatures based entirely on the previously implemented functions.
  • Would be adding tests and documentation soon.
  • Reviews and suggestions would be appreciated.

@pgRouting/admins

@robe2
Copy link
Member

robe2 commented Aug 18, 2023

  1. The functions have to be added as separate pull requests. Looks like you have at least 3 in here so need at least 3 pull requests
  2. Documentation is not complete
  3. All tests should pass
  4. You need more tests, but I think you are working on that.

@robe2
Copy link
Member

robe2 commented Aug 18, 2023

I'm going to close this one out since it needs to be split into more pull requests.

@robe2 robe2 closed this Aug 18, 2023
@sbdtu5498
Copy link
Member Author

@robe2 sure. I will break it down and will put it in 5 different PRs for

  • pgr_vertexBetweennessCentrality
  • pgr_edgeBetweennessCentrality
  • pgr_ithBandwidth
  • pgr_bandwidth
  • pgr_centralPointDominance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants