V2

[dmnsgn]

Changes:

• feat: convert require to import and module.exports to exports
• test: add missing test dependency tape and pex-geom
• docs: convert test to esm
• build: update dependencies (new seedrandom api and new breaking change simplex noise version)
• refactor: move everything to index.js (Move Random namespace inside index #2)
• feat: use Number.MAX_SAFE_INTEGER
• test: update for recent pex-math and pex-geom
• perf: remove intermediary const declaration in vec3InAABB
• feat: use default argument values
• feat: add FBM

TBD:

• feat: use local prng (Avoid seek leaking by crating local prng #4): does it means we can't Math.random and should only use random.float()?

Closes #2
Closes #4

[vorg]

About the random prng Replied on the issue #4

[dmnsgn]

TODO @dmnsgn add some notes about:

• Input coordinates bigger than 2^31 may not result in a noisy output anymore.
• Similar seeds might not result in different values for the same position in noise (see test)

[vorg]

Did we change seedrandom compared to older versions? Is it their issue?

[dmnsgn]

It is a seedrandom "standard ARC4 key scheduler cycles short keys" issue, we just never noticed as the test were always using the same 0/1 seeds:

pex-random/test/Random.js

Lines 245 to 247 in f199ef8

	rnd.seed(0);
	var r1 = rnd.noise2(x, y);
	rnd.seed(1);

While I rewrote it to be i/i+1:

pex-random/test/index.js

Lines 339 to 341 in 9293bd2

	random.seed(i);
	const r1 = random.noise2(x, y);
	random.seed(i + 1);

Test here

Update Random.js code to following and run node --test in v1:

var { describe, it } = require("node:test");
var assert = require("assert");
var rnd = require("../");

describe("Random", function () {
  describe("noise2(x, y)", function () {
    it("should return the different value for the same x,y", function () {
      for (var i = 0; i < 100; i++) {
        var x = 100 * Math.random();
        var y = 100 * Math.random();
        rnd.seed(i);
        var r1 = rnd.noise2(x, y);
        rnd.seed(i + 1);
        var r2 = rnd.noise2(x, y);
        assert.notEqual(r1, r2);
      }
    });
  });
});