[PREVIEW] deprecate last and pop, implement insert, erase, capacity #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
reviewed
Jan 2, 2020
| n2_i = (int)i; | ||
| memmove(&ec.indices[n2_i], &ec.indices[n2_i + 1], sizeof(unsigned char) * (ec.indices.size() - n2_i - 1)); | ||
| ec.indices.decr(); | ||
| ec.indices.erase(n2_i); |
There was a problem hiding this comment.
I see its a member function, still great!
jackgerrits
reviewed
Jan 2, 2020
| @@ -103,7 +103,7 @@ void io_buf::buf_write(char*& pointer, size_t n) | |||
| flush(); | |||
| else // Array is short, so increase size. | |||
| { | |||
| space.resize(2 * (space.end_array - space.begin())); | |||
| space.resize(2 * space.capacity()); | |||
jackgerrits
reviewed
Jan 2, 2020
| @@ -1080,7 +1080,7 @@ void allowed_actions_to_label(search_private& priv, size_t ec_cnt, const action* | |||
| template <class T> | |||
| void ensure_size(v_array<T>& A, size_t sz) | |||
| { | |||
| if ((size_t)(A.end_array - A.begin()) < sz) | |||
| if (A.capacity() < sz) | |||
jackgerrits
reviewed
Jan 2, 2020
jackgerrits
reviewed
Jan 2, 2020
jackgerrits
approved these changes
Jan 2, 2020
jackgerrits
reviewed
Jan 2, 2020
jackgerrits
reviewed
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usage of
back()andpop_back()gives a minor performance boost overlast()andpop()(mostly becausepop_back()doesn't return anything).Slight losses in performance can be see in some cases, notably
pop_back()calling the destructor andback()requiring a pointer dereference and not being able to RVO when copying in some cases; overall has better performance characteristics than the old interface. The old interface is maintained for compatibility.Additionally added 3 new functions from the standard interface (with some minor differences). Replaced relevant places with these function calls.