Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13426: Fix PBM collector memory leak #928

Merged
merged 8 commits into from
Oct 11, 2024
Merged

PMM-13426: Fix PBM collector memory leak #928

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4105dfd
add benchmark
idoqo Oct 8, 2024
e9e302b
disable pbm collector if there's an error during init
idoqo Oct 8, 2024
8e1a04a
drop benchmark code
idoqo Oct 8, 2024
8b9e5f7
close pbm client
idoqo Oct 8, 2024
3ebb401
format imports
idoqo Oct 9, 2024
e5864c9
Merge branch 'main' into fix-pbm-collector-memory-leak
idoqo Oct 9, 2024
7af416d
drop error log
idoqo Oct 10, 2024
1284ace
drop log level to info
idoqo Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion exporter/pbm_collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,16 @@ func (p *pbmCollector) collect(ch chan<- prometheus.Metric) {
logger.Errorf("failed to create PBM client from uri %s: %s", p.mongoURI, err.Error())
return
}
defer func() {
err := pbmClient.Close(p.ctx)
if err != nil {
logger.Errorf("failed to close PBM client: %v", err)
}
}()

pbmConfig, err := pbmClient.GetConfig(p.ctx)
if err != nil {
logger.Errorf("failed to get PBM configuration: %s", err.Error())
logger.Warnf("failed to get PBM configuration: %s", err.Error())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be Info level if we expect that pbm config might not exist there

}

if pbmConfig != nil {
Expand Down