Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow path in Connection Address #677

Closed
wants to merge 7 commits into from

Conversation

snipcola
Copy link

@snipcola snipcola commented Oct 27, 2024

Currently, if the connection address has a path, the port will end up after the path.
001150 Zen Browser 2024-10-27 16 41 06

001152 Zen Browser 2024-10-27 20 58 48

001154 Zen Browser 2024-10-27 20 59 50

This PR ensures the path comes after the port.
001146 Zen Browser 2024-10-27 16 39 58

001132 Zen Browser 2024-10-27 15 55 48

001156 Zen Browser 2024-10-27 21 00 18

@RMartinOscar
Copy link
Contributor

We should probably change Domain Name to Enpoint if we add support for Paths, you shouldn't put port in this field also the scheme part is useless filamentphp gets rid of it

@snipcola
Copy link
Author

snipcola commented Oct 27, 2024

you shouldn't put port in this field

Can you elaborate, what field are you referencing?

@snipcola snipcola changed the title Allow path in FQDN Allow path in Connection Address Oct 27, 2024
@RMartinOscar
Copy link
Contributor

you shouldn't put port in this field

Can you elaborate, what field are you referencing?

The domaine Name field shouldn't include port if you want to use a custom port use the Port field
image
image

@snipcola
Copy link
Author

you shouldn't put port in this field

Can you elaborate, what field are you referencing?

The domaine Name field shouldn't include port if you want to use a custom port use the Port field image image

Oh, right, I already assumed that was the case.
Only for the example, I've predefined the port. daemon_listen would be used, like usual.

@Boy132
Copy link
Member

Boy132 commented Oct 28, 2024

Why would you use a fqdn with a path? This sounds like a super edge case.

@snipcola
Copy link
Author

snipcola commented Oct 28, 2024

Why would you use a fqdn with a path? This sounds like a super edge case.

I understand it might be an edge case. There are certain scenarios where it could be useful; for example, if users want to host multiple applications under the same domain. In my use case, I've set up all of my services under dokploy, which uses traefik, and allowing a path in the address allows me to do something like:

  • game.domain.com
  • game.domain.com/node

It also allows traefik to request one less certificate from letsencrypt, which probably doesn't make too much of a difference - but I do prefer it.

001164 Zen Browser 2024-10-28 10 55 08

However, unfortunately it wasn't plug and play. There is one difference I had to make, which was to tell traefik to strip the path from the request, which in my case was /node, like so:

traefik.http.middlewares.pelican-wings.stripprefix.prefixes: /node
traefik.http.routers.pelican-wings.middlewares: pelican-wings@docker

@lancepioch
Copy link
Member

It also allows traefik to request one less certificate from letsencrypt, which probably doesn't make too much of a difference - but I do prefer it.

You always have the option of requesting a wildcard from LE if needed. The current limit is 50 per week per IP which is plenty for 99% of people.

Subdomains are free, please use them instead of paths! Sorry, this would just add too much overhead for no appreciable benefit. We do appreciate the contributions though!

@lancepioch lancepioch closed this Oct 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@snipcola snipcola deleted the path-fqdn branch October 28, 2024 21:31
@pelican-dev pelican-dev deleted a comment from github-actions bot Oct 31, 2024
@pelican-dev pelican-dev deleted a comment from snipcola Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants