-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow path in Connection Address #677
Conversation
We should probably change Domain Name to Enpoint if we add support for Paths, you shouldn't put port in this field also the scheme part is useless filamentphp gets rid of it |
Can you elaborate, what field are you referencing? |
Why would you use a fqdn with a path? This sounds like a super edge case. |
I understand it might be an edge case. There are certain scenarios where it could be useful; for example, if users want to host multiple applications under the same domain. In my use case, I've set up all of my services under dokploy, which uses traefik, and allowing a path in the address allows me to do something like:
It also allows traefik to request one less certificate from letsencrypt, which probably doesn't make too much of a difference - but I do prefer it. However, unfortunately it wasn't plug and play. There is one difference I had to make, which was to tell traefik to strip the path from the request, which in my case was traefik.http.middlewares.pelican-wings.stripprefix.prefixes: /node
traefik.http.routers.pelican-wings.middlewares: pelican-wings@docker |
You always have the option of requesting a wildcard from LE if needed. The current limit is 50 per week per IP which is plenty for 99% of people. Subdomains are free, please use them instead of paths! Sorry, this would just add too much overhead for no appreciable benefit. We do appreciate the contributions though! |
Currently, if the connection address has a path, the port will end up after the path.
This PR ensures the path comes after the port.