-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Word templates for 2024 for ResDoc #263
base: main
Are you sure you want to change the base?
Conversation
I hadn't really use the Word rendering before, but I am noticing that the functions @PaulRegular do you use these functions much? Do they work as intended for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me - thanks! I haven't used the Res Doc word functionality much.
I recall running into formatting issues with However, I've yet to update from the 2021 to 2024 templates. Perhaps we should meet soon to discuss a pull of the resdocx branch? I'm happy with how it's behaving for Word output, but would be good to have your oversight to make sure this plays nicely with the rest of the package. |
@PaulRegular let's indeed touch base and come up with a plan to bring your resdocx branch into the fold, and do the same thing for the fsar branch I believe that the new CSAS FSAR template is nearing completion, so it would be good to have all the Word output functionalities and the new FSAR template implemented into the main branch (we could then close issue #242) |
@seananderson while the PR passes the tests here on GitHub, running the tests in RStudio generates a number of fails, why would that be? |
upgrading the 2021 Word templates to 2024, with associated changes to
utils.R
,resdoc-word.R
, andsr-word.R