Ability to configure request timeouts #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you bump to 60s? We have some requests that can take quite awhile (compiling, flashing, etc.). |
|
Definitely, good idea @brycekahle . I just did. |
|
@brycekahle When are you guys planning to make a new release? Will this PR make it to that next release? |
m-mcgowan
added a commit
that referenced
this pull request
May 16, 2017
Closed
m-mcgowan
added a commit
that referenced
this pull request
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to address what was mentioned in this issue: #19
I chose the default timeout to be 30 seconds, but let me know if this doesn't work for you guys.
Thanks!