Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Offline mode #435

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

Conversation

vdkdamian
Copy link
Contributor

@vdkdamian vdkdamian commented Dec 27, 2022

New Pull Request Checklist

Issue Description

This adds the possibility to use ParseSwift with offline mode. Objects will be stored on device if needed and can be fetched when internet connection is back.

Closes: #429

Approach

I will add playground examples on how to use it.

TODOs before merging

  • Test
  • Linting
  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add playground examples

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 27, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@vdkdamian vdkdamian changed the title Offline mode feat: Offline mode Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Attention: Patch coverage is 83.59942% with 113 lines in your changes are missing coverage. Please review.

Project coverage is 87.53%. Comparing base (3d4bb13) to head (e34dd82).

Files Patch % Lines
Sources/ParseSwift/Storage/LocalStorage.swift 89.22% 46 Missing ⚠️
Sources/ParseSwift/Types/Query.swift 68.65% 42 Missing ⚠️
Sources/ParseSwift/Objects/ParseObject.swift 61.11% 21 Missing ⚠️
Sources/ParseSwift/Extensions/URLSession.swift 80.00% 2 Missing ⚠️
Sources/ParseSwift/Storage/ParseFileManager.swift 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   90.37%   87.53%   -2.84%     
==========================================
  Files         161      162       +1     
  Lines       16267    16929     +662     
==========================================
+ Hits        14701    14819     +118     
- Misses       1566     2110     +544     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vdkdamian
Copy link
Contributor Author

I reached the limit of what I can cover for CodeCov

@mtrezza mtrezza closed this Mar 28, 2024
@mtrezza mtrezza reopened this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add offline object saving
2 participants