refactor: Remove framework builder for assets #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1751 +/- ##
===========================================
+ Coverage 64.42% 78.22% +13.80%
===========================================
Files 200 307 +107
Lines 23177 36981 +13804
===========================================
+ Hits 14931 28929 +13998
+ Misses 8246 8052 -194 ☔ View full report in Codecov by Sentry. |
2 tasks
|
🎉 This change has been released in version 3.0.0 |
eeallen1
added a commit
to eeallen1/Parse-SDK-iOS-OSX
that referenced
this pull request
May 6, 2024
* commit 'ef9b00de9eeeca7fddfe9439141f5141ff5dac02': (86 commits) chore(release): 3.0.0 [skip ci] ci: Fix release workflow (parse-community#1782) feat: Remove `ParseFacebookUtils` and `ParseTwitterUtils` (parse-community#1779) feat: Add `PFObject.isDataAvailableForKey` to check if data is available for individual key (parse-community#1756) ci: Bump ip from 2.0.0 to 2.0.1 (parse-community#1772) ci: Fix failing CI by pinning bundler version (parse-community#1778) refactor: Remove Carthage dependency (parse-community#1763) refactor: Remove OCMock Carthage dependency (parse-community#1754) ci: Run CI on Xcode 15 and macOS 13 (parse-community#1753) refactor: Update ruby dependencies (parse-community#1752) refactor: Remove framework builder for assets (parse-community#1751) chore(release): 2.7.3 [skip ci] fix: Compilation errors in `ParseLiveQuery` using `Starscream` 4.0.6 (parse-community#1749) docs: Add changelog note about missing assets (parse-community#1750) chore(release): 2.7.2 [skip ci] fix: Compilation errors `Undefined symbol` and `SystemConfiguration not found` on watchOS (parse-community#1748) ci: Remove publishing release assets (parse-community#1745) ci: Fix and build Starter Projects (parse-community#1744) chore(release): 2.7.1 [skip ci] fix: Compilation error on macOS `Undefined symbol: OBJC_CLASS$_PFProductsRequestHandler` (parse-community#1739) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
xctoolchain framework builder doesn't work for release configuration builds on Xcode 14+.
Closes: N/A
Approach
Eventually we would want to create xcframework assets for publishing. We can use swift-create-xcframework or this Makefile that I'm making. They far are simpler solutions than working with xctoolchain.
TODOs before merging