Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubies and rails supports #164

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Update rubies and rails supports #164

merged 2 commits into from
Jul 13, 2024

Conversation

nicolas-brousse
Copy link
Member

@nicolas-brousse nicolas-brousse commented Jul 12, 2024 •
edited
Loading

  • Add ruby 3.3 support
  • Remove ruby 2.7 support
  • Remove Rails 6.0 support
  • Fix sqlite requirement

@nicolas-brousse nicolas-brousse added the bug Something isn't working label Jul 12, 2024
@nicolas-brousse nicolas-brousse self-assigned this Jul 12, 2024
@nicolas-brousse
Copy link
Member Author

@Spone Maybe I should also drop support fort old rubies and rails versions. What do you think about?

@Spone
Copy link
Collaborator

Spone commented Jul 12, 2024

@nicolas-brousse we can drop Rails 6.0, but let's keep 6.1 since ViewComponent supports it.

@Spone
Copy link
Collaborator

Spone commented Jul 12, 2024 •
edited
Loading

We can also remove Ruby 2.7 that is no longer supported.

Let's keep Ruby 3.0 (for Rails 6.1).

@nicolas-brousse
Copy link
Member Author

@Spone should we keep test on view_component v2.* for latest rails versions too?

@Spone
Copy link
Collaborator

Spone commented Jul 13, 2024

Yes, I think. At least until ViewComponent v4 is released.

@nicolas-brousse
Copy link
Member Author

Ok, I've to dig to understand how to fix this https://github.com/pantographe/view_component-form/actions/runs/9914182370/job/27392784399?pr=164#step:4:1174. Seems to be the last thing that block the CI

@nicolas-brousse nicolas-brousse changed the title fix: update sqlite gem requirements Update rubies and rails supports Jul 13, 2024
@nicolas-brousse nicolas-brousse marked this pull request as ready for review July 13, 2024 08:45
@nicolas-brousse nicolas-brousse merged commit 1f38381 into main Jul 13, 2024
120 checks passed
@nicolas-brousse nicolas-brousse deleted the fix-ci branch July 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spone Spone Spone approved these changes

Assignees

@nicolas-brousse nicolas-brousse

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-brousse @Spone