Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add input "extensions" #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add input "extensions" #21

wants to merge 2 commits into from

Conversation

permafrost06
Copy link

Add support for extensions input which is passed to phpcs so that it only checks files of that specific type. I was getting false positive reports of js files being minified. I thought, why check js files at all?

@permafrost06 permafrost06 requested a review from a team as a code owner November 11, 2024 16:50
jazzsequence
jazzsequence approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few sugestions, but otherwise this looks like a good addition.

action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@permafrost06
Copy link
Author

permafrost06 commented Nov 13, 2024 •
edited
Loading

I've updated and tested the command with php as the default. Everything seems to be working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzsequence jazzsequence jazzsequence approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@permafrost06 @jazzsequence