Support setting direct_running_mode for LocalDirectRunner #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 96.46% 96.47%
=======================================
Files 15 15
Lines 509 510 +1
=======================================
+ Hits 491 492 +1
Misses 18 18 ☔ View full report in Codecov by Sentry. |
|
#66 sets the logging config |
|
Changing this default would reduce multi-core performance when running locally, so maybe let's hold off for a second. |
This was referenced Aug 19, 2023
|
Hey Yuvi - going through and attempting to get things aligned and cleaned up in terms of PRs and I'm wondering if maybe we should just accept the default of multi_processing but keep the configurable argument so that it is easier to enable the more debug-friendly multi_threading case? |
This also changes the default local one from multi_processing to multi_threading. The primary use here is to make the logging config from the *runner* be inherited by the *workers* too, which helps with debugging quite a bit.
moradology
force-pushed
the
fix-direct-running-mode
branch
from
82c45e7
to
ff36901
Compare
|
@moradology that sounds like a good way to proceed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the default local one from multi_processing to multi_threading. The primary use here is to make the logging config from the runner be inherited by the workers too, which helps with debugging quite a bit.