Sheshtawy #94
Open
Sheshtawy #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing tests for deaf grandma
Implement FizBuzz tests
mikegee
reviewed
Jun 13, 2018
|
|
||
| upper = /[A-Z]+/ | ||
| lower = /[A-Z]?[a-z]+/ | ||
| bye = /\A(BYE ?){3}\z/ |
There was a problem hiding this comment.
These three regular expressions could be extracted to constants, since they are the same every time this method is called.
mikegee
reviewed
Jun 13, 2018
| upper = /[A-Z]+/ | ||
| lower = /[A-Z]?[a-z]+/ | ||
| bye = /\A(BYE ?){3}\z/ | ||
| response = '' |
There was a problem hiding this comment.
I don't think we need this local variable. Below, you conditionally assign different values to it, but you don't do anything else with response. I'm pretty sure this method will behave the same if you don't have this local variable and just put those three strings in each part of the if/elsif/elsif.
mikegee
reviewed
Jun 13, 2018
| response = 'SPEAK UP SONNY!' | ||
| elsif bye.match(input) | ||
| response = 'SEE YOU LATER SONNY!' | ||
| elsif upper.match(input) |
There was a problem hiding this comment.
What if the input matches none of these regular expressions? I think that would happen if there is no letter in the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo