Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed, Working on Saas and HAML format #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rpriya123
Copy link

@degoeym
Copy link

degoeym commented Jan 14, 2016

For your h1 and footer tags, you shouldn't need all those border-color-* attributes to handle the coloring, though they're perfectly usable and do get you the desired result. See if you can:

  1. Find another way to handle the coloring of the needed borders, and/or;

  2. Consolidate the numerous border-color-* attributes into a single attribute that handles everything (which can also lead to an answer for item one now that I think of it).

Also, cleanup the CSS so that tabbed items are uniform. Nothing makes developers upset faster than messy, improperly formatted code. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants