Hari's solution #36

hkdahal · 2018-01-26T15:22:48Z

mikegee · 2018-01-30T17:26:38Z

source/app/controllers/urls_controller.rb

+  def route_me
+    url = Url.find_by_short_url params[:short_url]
+
+    if url.nil?


I prefer if url (drop .nil?) to phrase things positively, and put the "happy path" code in the top of the if/else.

mikegee · 2018-01-30T17:28:28Z

source/app/controllers/urls_controller.rb

+    if url.nil?
+      redirect_to root_path
+    else
+      url.update('click_count' => url.click_count + 1)


ActiveRecord has a method for this kind of thing.

There's a subtle bug as currently written. Do you see it?

mikegee · 2018-01-30T17:30:37Z

source/app/models/url.rb

+
+  def long_url_responds
+    link = URI.parse(long_url)
+    if link.is_a?(URI::HTTP) || link.is_a?(URI::HTTPS)


This bit seems very similar to long_url.start_with? 'http://', 'https://' in the above method. I think a concept is duplicated here. 🤔

Hari Dahal added 4 commits January 25, 2018 12:49

release 0 - shorten given url and redirect

a329cd9

release 1 - count clicks

a5a2db0

release 2&3 - added url validations

6b4ecd9

added bootstrap to FrontEnd layouts

d16c76c

mikegee reviewed Jan 30, 2018

View reviewed changes

Provide feedback