Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matt Crocco solution #31

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Matt Crocco solution #31

wants to merge 9 commits into from

Conversation

glossawy
Copy link

Matthew Crocco added 9 commits June 11, 2017 23:57
… counted twice

`turbolinks` is included in rails by default, unfortunately it caused a duplicate request
to be sent (identically) to the href target. This is fine for typical links, but not for links
registering clicks.

Helpers were added (`link_to_noturbo` and `link_to_short`) that set the `data-turbolinks` attribute to
false by default, disabling turbolinks for links created by those helpers.
@glossawy
Copy link
Author

@Drm2 @sjreich This is a bit longer (though quite a bit is generated code) but if you guys happened to have time to skim I would really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant