completed challenge #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, Ubuntu 15.10 had an issue compiling Nokogiri dependencies, so I rebuilt the project with the latest version of rails. |
|
|
||
| def create | ||
| # validate that the user entered a url | ||
| if url_params[:address].size <= 3 || url_params[:address].to_s.match(/^.+\..+/).blank? |
There was a problem hiding this comment.
I'd push all of this validation logic into the model if possible or wrap it into some sort of validator class that raises errors when params don't meet a condition then you can use rescue_from to handle the exceptions/render error messaging.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app I've built uses a base 65 compression algorithm to compress the id of the URL table. This is similar to Bitly, which uses a base 64 algorithm. The extra character I've added is a '-'. It will also check for duplicates in the create method of urls_controller.rb, and will display the existing shortened URL if a duplicate is entered. It will also validate user input to ensure that it's at least 3 character and contains at least one full stop character.