[P3] Fix persisting sleep animation when sprite is already loaded

[acelynnzhang]

What are the changes the user will see?

Pokémon animation speeds will function normally after reloading a session that was saved when an enemy Pokémon was asleep.

Why am I making these changes?

Fixes #4465

What are the changes from a developer perspective?

Calling PokemonSpeciesForm.loadAssets will reset the framerate when previously nothing would be done if the sprite was already loaded.

Screenshots/Videos

Before:

before.mp4

After:

after.mp4

How to test the changes?

• Import session using the session data linked here
• Use Spore
• Save + quit
• Load session again

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• [ ] Have I considered writing automated tests for the issue?
• [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[chaosgrimmon]

Seems like a straightforward response to Quit to menu recycling the scene?
I very much do dislike the fact that framerates are fixed for the entire species though.

[pom-eranian]

Confirmed, fps is reset. video

[acelynnzhang]

I very much do dislike the fact that framerates are fixed for the entire species though.

Are there any cases where the framerate is not 12? I referenced this code when getting rid of the effects of sleep.

[chaosgrimmon]

@acelynnzhang

Also, if you happen to know which part of the code causes the framerate reduction, it'd save me a fair bit of time looking for it.

[acelynnzhang]

Also, if you happen to know which part of the code causes the framerate reduction, it'd save me a fair bit of time looking for it.
Yep!

[chaosgrimmon]

Are there any cases where the framerate is not 12?

Great question, and I suppose the easy answer is previously, when it was reduced by a member of the Species being Asleep.

(Since the code is in pokemon-species, it affects every single future instantiation of that Species, provided that the scene was still in use. Because this doesn't affect existing instances, it did not appear to cause problems if, say, you Slept only one enemy Pokemon in a double battle and they were the same Species, but upon Quit+Reload, both would have their assets loaded, causing both to be slower than intended)

PokeRogue.2024-10-03.16-13-55.mp4

PokeRogue.2024-10-03.16-14-19.mp4

[chaosgrimmon]

tested, lgtm

PokeRogue.2024-10-03.16-03-56.mp4

[chaosgrimmon]

Yep!

That's really interesting given the statement in the Issue, if the actual code should only be setting framerate to a flat 4.

This compounds every time, which may result in ridiculously low animation speeds if repeated enough time.

(the reason I had to ask is in fact because it seemed like it wasn't getting slower upon repeated attempts)

[acelynnzhang]

(the reason I had to ask is in fact because it seemed like it wasn't getting slower upon repeated attempts)

I was also unable to see the compounding in my testing. I used DevTools to track the framerate changes.