-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move] Update Tera Starstorm (still Partial), Readd Partial tag to Tera Blast #4549
Conversation
Fusions exist, so this will need to account for those. That and also this is still partial for the same reasons tera blast is, |
addressed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits, looks good otherwise
What are the changes the user will see?
Tera Starstorm updated implemention
Why (P)? - both do not ignore abilities that affect stats
Why am I making these changes?
partially implemented move, missing the ff when used by Terapagos in its Stellar Form:
What are the changes from a developer perspective?
TeraBlastCategoryAttr
class name toTeraMoveCategoryAttr
to align its usecaseTeraStarstormTypeAttr
to handle type changing logic for the moveScreenshots/Videos
How to test the changes?
Checklist
beta
as my base branchnpm run test
)