Fix JS after conversion from CoffeeScript #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
brian-kephart
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
The Ruby parts of this look good.
The JS parts look good, I think. The whole jQuery-ness of it all is throwing me off a little bit, it's been awhile. 😅 I don't think any of those explicit returns were necessary, and it looks to me like some of them could actually be harmful, so good change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053
Changes
#switch_nav_menu_formdiv id in thenav_menu, which has been messed on Decaffeinate.rubocop_todo.yml