New MAAS (Metal as a Service) infrastructure. #53
Conversation
| infrastructure.getCredentials().getPassword(), | ||
| infrastructure.isAllowSelfSignedSSLCertificate()); | ||
| } catch (RemoteConnectFailureException e) { | ||
| throw new RuntimeException("ERROR trying to create MaasClient with infrastructure : " + infrastructure, e); |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one. 
| private Function<Infrastructure, MaasClient> buildMaasClient = memoise(infrastructure -> maasClientBuilder.buildMaasClientFromInfrastructure(infrastructure)); | ||
|
|
||
| private Function<Infrastructure, MaasClient> memoise(Function<Infrastructure, MaasClient> fn) { | ||
| return (a) -> maasClientCache.computeIfAbsent(a, fn); |
There was a problem hiding this comment.
Remove the parentheses around the "a" parameter
| maasClientCache.remove(infrastructure); | ||
| } | ||
|
|
||
| private Function<Infrastructure, MaasClient> buildMaasClient = memoise(infrastructure -> maasClientBuilder.buildMaasClientFromInfrastructure(infrastructure)); |
There was a problem hiding this comment.
Move this variable to comply with Java Code Conventions.
| @Override | ||
| public void deleteInstance(Infrastructure infrastructure, String instanceId) { | ||
| if (!maasProviderClientCache.getMaasClient(infrastructure).releaseMachineById(instanceId)) { | ||
| throw new RuntimeException("ERROR when deleting MAAS instance : " + instanceId); |
There was a problem hiding this comment.
Define and throw a dedicated exception instead of using a generic one.
| @Component | ||
| public class MaasProvider implements CloudProvider { | ||
|
|
||
| private final Logger logger = Logger.getLogger(MaasProvider.class); |
There was a problem hiding this comment.
Make the "logger" logger private static final.
| Set<Instance> instances = futureMachines.stream().map(futureMachine -> { | ||
| try { | ||
| return futureMachine.get(); | ||
| } catch (InterruptedException | ExecutionException e) { |
There was a problem hiding this comment.
Either log or rethrow this exception.
| private final Logger logger = Logger.getLogger(MaasProvider.class); | ||
|
|
||
| @Getter | ||
| private final String type = "maas"; |
There was a problem hiding this comment.
Make this final field static too.
|
|
||
| @Override | ||
| public Set<Image> getAllImages(Infrastructure infrastructure) { | ||
| throw new NotSupportedException("Operation not supported for MAAS"); |
There was a problem hiding this comment.
Define a constant instead of duplicating this literal "Operation not supported for MAAS" 3 times.
|
SonarQube analysis reported 8 issues
Watch the comments in this conversation to review them. |
|
retest this please |
1 similar comment
|
retest this please |
Implementation of the new MAAS (Metal as a Service) cloud infrastructure.
The new infrastructure essentially rely on the Java REST Client developped by ActiveEon: https://github.com/ow2-proactive/maas-rest-client.
Note: It is assumed that the machines to deploy are already registered to the MAAS region/rack controllers. Usually a first boot is enough to register new machines when controllers are configured with auto-discovery feature. New machines may need to be configured manually if the power parameters can not be retrieved automatically (eg. IPMI configuration). Once the machines are recognized by MAAS (systemId generated) they can be allocated, deployed, and released by the connector-iaas.
For now, the deployment can be done in two different ways:
Supported feature:
Limitations:
Improvements: