improve delete nic #400
Open
improve delete nic #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-mgo
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-mgo
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-mgo
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-mgo
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-mgo
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
up to this patch, if the API was returning an empty array on ReadNics after a DeleteNic, the delete_nic operation on terraform was waiting for the end of the timeout to validate the delete. Not anymore. Note that this bug did happen on Ricochet, but was not hapenning on the API because the API was returning a nic either in deleting or deleted state. But it was still a bug nevertheless. Signed-off-by: Matthias Gatto <[email protected]>
outscale-mgo
force-pushed
the
improve_deldete_nic
branch
from
21b4b4c
to
1916f8e
Compare
outscale-mgo
temporarily deployed
to
test-us-east-2
GitHub Actions
Inactive
outscale-mgo
had a problem deploying
to
test-us-east-2
GitHub Actions
Failure
outscale-mgo
had a problem deploying
to
test-eu-west-2
GitHub Actions
Failure
outscale-mgo
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-mgo
temporarily deployed
to
test-eu-west-2
GitHub Actions
Inactive
outscale-toa
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up to this patch, if the API was returning an empty array on ReadNics after a DeleteNic, the delete_nic operation on terraform was waiting for the end of the timeout to validate the delet.
Not anymore.
Note that this bug did happen on ricochet, but was not hapenning on the API because the api was returning a nic either in deleting or deleted state. But it was still a bug nethertheless.