Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 Digit 7 Segment Display #275

Merged
merged 37 commits into from
Nov 18, 2024
Merged

4 Digit 7 Segment Display #275

merged 37 commits into from
Nov 18, 2024

Conversation

leandrumartin
Copy link
Collaborator

@leandrumartin leandrumartin commented Oct 28, 2024

Resolves #44. Added controller and helper for 4-digit 7-segment display that utilizes Seyun's in-progress implementation of the single-digit display.

Controller has API endpoint for displaying a number up to 4 digits in length. The helper uses the work-in-progress SevenSegmentDisolayHelper @Ed0827 is writing in another PR in order to avoid reusing code.

@leandrumartin leandrumartin self-assigned this Oct 28, 2024
@leandrumartin leandrumartin marked this pull request as ready for review October 28, 2024 21:43
…naut-44

# Conflicts:
#	components/src/main/resources/application.yml
Copy link
Collaborator

@yrlmanoharreddy yrlmanoharreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is on the right track, but before we can proceed, please test the code with actual hardware to validate the correct communication protocol. This is essential to ensure the sensor operates as expected. Additionally, I noticed that you used the SevenSegmentDisplayHelper class, which isn’t currently available in the package (I understand Seyun is working on it). Without hardware testing and the missing class, I can’t approve the PR just yet. Once these changes are addressed, we’ll be in a good place to move forward

@leandrumartin
Copy link
Collaborator Author

Additionally, I noticed that you used the SevenSegmentDisplayHelper class, which isn’t currently available in the package (I understand Seyun is working on it). Without ... the missing class, I can’t approve the PR just yet. Once these changes are addressed, we’ll be in a good place to move forward

How should we proceed with fixing the issue of the missing class? Would we have to ensure that Seyun's PR is merged first?

…play. Commented out tests. Stubbed out method for displaying numbers, for testing
…ment display requires multiple digital output pins.
… output configuration. You will not be missed.
@leandrumartin
Copy link
Collaborator Author

The component now no longer relies on any other Pi4Micronaut components. Instead, the helper class utilizes the Seven Segment Display component included in Pi4J's CrowPi.

The controller includes API endpoints for enabling/disabling the display, displaying a value, and clearing the display. Displayed values can include digits, letters A-F, hyphen (-), and space, with decimal points between the four digits.

There is also a comprehensive set of unit tests for the helper class.

@leandrumartin leandrumartin changed the title Pi4Micronaut-44 4 Digit 7 Segment Display Nov 11, 2024
leandrumartin and others added 9 commits November 11, 2024 13:24
…egmentDisplayHelper.java, made something that actually works as tested with hardware :)
# Conflicts:
#	components/src/main/java/com/opensourcewithslu/components/controllers/FourDigitSevenSegmentDisplayController.java
#	pi4micronaut-utils/src/main/java/com/opensourcewithslu/outputdevices/FourDigitSevenSegmentDisplayHelper.java
#	pi4micronaut-utils/src/test/java/com/opensourcewithslu/outputdevices/FourDigitSevenSegmentDisplayHelperTest.java
…ge a previous commit had done to the servo motor config
Copy link
Collaborator

@yrlmanoharreddy yrlmanoharreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave support to 4 digit seven segment dispaly and also made documentation for it.
Resolved #275 #282

@yrlmanoharreddy yrlmanoharreddy merged commit d5985ac into main Nov 18, 2024
6 checks passed
@yrlmanoharreddy yrlmanoharreddy deleted the Pi4Micronaut-44 branch November 18, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 Digit 7 Segment Display
2 participants