-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4 Digit 7 Segment Display #275
Conversation
…lper with four displays initialized.
…ntative implementation of single-digit seven-segment display helper.
…naut-44 # Conflicts: # components/src/main/resources/application.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is on the right track, but before we can proceed, please test the code with actual hardware to validate the correct communication protocol. This is essential to ensure the sensor operates as expected. Additionally, I noticed that you used the SevenSegmentDisplayHelper class, which isn’t currently available in the package (I understand Seyun is working on it). Without hardware testing and the missing class, I can’t approve the PR just yet. Once these changes are addressed, we’ll be in a good place to move forward
How should we proceed with fixing the issue of the missing class? Would we have to ensure that Seyun's PR is merged first? |
…orrect type, added tests
…play. Commented out tests. Stubbed out method for displaying numbers, for testing
…ment display requires multiple digital output pins.
… output configuration. You will not be missed.
The component now no longer relies on any other Pi4Micronaut components. Instead, the helper class utilizes the Seven Segment Display component included in Pi4J's CrowPi. The controller includes API endpoints for enabling/disabling the display, displaying a value, and clearing the display. Displayed values can include digits, letters A-F, hyphen (-), and space, with decimal points between the four digits. There is also a comprehensive set of unit tests for the helper class. |
…i4Micronaut-44
…egmentDisplayHelper.java, made something that actually works as tested with hardware :)
…s, update method name
# Conflicts: # components/src/main/java/com/opensourcewithslu/components/controllers/FourDigitSevenSegmentDisplayController.java # pi4micronaut-utils/src/main/java/com/opensourcewithslu/outputdevices/FourDigitSevenSegmentDisplayHelper.java # pi4micronaut-utils/src/test/java/com/opensourcewithslu/outputdevices/FourDigitSevenSegmentDisplayHelperTest.java
…ge a previous commit had done to the servo motor config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #44. Added controller and helper for 4-digit 7-segment display that utilizes Seyun's in-progress implementation of the single-digit display.
Controller has API endpoint for displaying a number up to 4 digits in length. The helper uses the work-in-progress
SevenSegmentDisolayHelper
@Ed0827 is writing in another PR in order to avoid reusing code.