Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ory/herodot #1124

Merged
merged 2 commits into from
Jul 26, 2023
Merged

chore: bump ory/herodot #1124

merged 2 commits into from
Jul 26, 2023

Conversation

alnr
Copy link
Collaborator

@alnr alnr commented Jul 26, 2023

Also minor dependency cleanup. This should help with client-canceled requests showing up as 500 errors in logs. They should now be reported as 499s.

Also minor dependency cleanup
@alnr alnr requested a review from zepatrik July 26, 2023 14:00
@alnr alnr self-assigned this Jul 26, 2023
@alnr alnr requested a review from aeneasr as a code owner July 26, 2023 14:00
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1124 (d0407d2) into master (75eb682) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head d0407d2 differs from pull request most recent head b1826f8. Consider uploading reports for the commit b1826f8 to get more accurate results

@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          80       80           
  Lines        3863     3863           
=======================================
  Hits         3022     3022           
  Misses        566      566           
  Partials      275      275           
Files Changed Coverage Δ
pipeline/authn/authenticator_bearer_token.go 74.24% <ø> (ø)
pipeline/authn/authenticator_cookie_session.go 80.18% <ø> (ø)
pipeline/authn/authenticator_jwt.go 83.05% <ø> (ø)
...peline/authn/authenticator_oauth2_introspection.go 80.00% <ø> (ø)
pipeline/errors/when.go 72.11% <ø> (ø)

@alnr alnr enabled auto-merge (rebase) July 26, 2023 14:51
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alnr alnr merged commit 58690ae into master Jul 26, 2023
21 checks passed
@alnr alnr deleted the herodot branch July 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants