Change Exploration defaults
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
reviewed
Oct 25, 2023
Co-authored-by: Maxence Thévenet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default value of some
Explorationparameters:run_async=False. I think this is a more adequate default. Only when the time cost can change significantly between evaluations should the user setrun_async=True. Otherwise, the current default was resulting in some performance loss, because new evaluations are no longer generated in batch unless the previous evaluations finished at exactly the same time.max_evals=np.inf. By default, allow the exploration to run indefinitely. This is useful when running interactively in substeps withExploration.run(n_evals)without predefining a maximum limit.sim_workers=1. By default, run with only 1 worker.