Fix Expiration Date Checking in OpenID4VPPresentationActivity #782
+251
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeus
approved these changes
Nov 18, 2024
...in/java/com/android/identity_credential/wallet/presentation/OpenID4VPPresentationActivity.kt
Show resolved
Hide resolved
wallet/src/test/java/com/android/identity_credential/wallet/OpenID4VPTest.kt
Outdated
Show resolved
Hide resolved
suzannajiwani
force-pushed
the
time-check-fix
branch
from
efd9469
to
f2bf669
Compare
Fix expiration date checking in OpenID4VPPresentationActivity and allow issuance time to be the same as now. Also added tests to OpenID4VPTest to confirm expected behavior for expired, not yet issued, and not yet valid JWTs. Tested-by: Adding examples to OpenID4VPTest.kt Signed-off-by: Suzanna Jiwani <[email protected]>
suzannajiwani
force-pushed
the
time-check-fix
branch
from
f2bf669
to
fbce8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix expiration date checking in OpenID4VPPresentationActivity and allow issuance time to be the same as now. Also added tests to OpenID4VPTest to confirm expected behavior for expired, not yet issued, and not yet valid JWTs.
Tested-by: Adding examples to OpenID4VPTest.kt