BINDINGS/GO: Add RMA support #10214
Open
BINDINGS/GO: Add RMA support #10214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemy-Mellanox
force-pushed
the
topic/go-rma
branch
from
0ca3eef
to
e34c38c
Compare
ofirfarjun7
reviewed
Oct 7, 2024
Artemy-Mellanox
force-pushed
the
topic/go-rma
branch
from
1c77a86
to
9bb4bb7
Compare
ofirfarjun7
reviewed
Oct 13, 2024
Artemy-Mellanox
force-pushed
the
topic/go-rma
branch
from
88146e3
to
c924888
Compare
ofirfarjun7
approved these changes
Oct 20, 2024
rakhmets
reviewed
Nov 7, 2024
| func (m *UcpMemory) Pack() (*UcpRKeyBuffer, error) { | ||
| result := &UcpRKeyBuffer{} | ||
|
|
||
| if status := C.ucp_rkey_pack(m.context, m.memHandle, &result.buffer, &result.size); status != C.UCS_OK { |
There was a problem hiding this comment.
ucp_rkey_pack is deprecated. Please use ucp_memh_pack.
| size C.size_t | ||
| } | ||
|
|
||
| func NewRKeyBuffer(buffer []byte) *UcpRKeyBuffer { |
There was a problem hiding this comment.
It seems that the method is unused.
| } | ||
|
|
||
| func (m *UcpMemory) Pack() (*UcpRKeyBuffer, error) { | ||
| result := &UcpRKeyBuffer{} |
There was a problem hiding this comment.
Suggested change
| result := &UcpRKeyBuffer{} | |
| rkeyBuffer := &UcpRKeyBuffer{} |
| } | ||
|
|
||
| func (e *UcpEp) Unpack(buffer *UcpRKeyBuffer) (*UcpRKey, error) { | ||
| result := &UcpRKey{} |
There was a problem hiding this comment.
Suggested change
| result := &UcpRKey{} | |
| rkey := &UcpRKey{} |
| } | ||
| } | ||
|
|
||
| func (m *UcpMemory) Pack() (*UcpRKeyBuffer, error) { |
There was a problem hiding this comment.
Please add a description for each interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.