C++ version update #2604
Open
C++ version update #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superwhd
reviewed
Nov 19, 2024
| @@ -52,7 +52,7 @@ if(NOT CMAKE_C_STANDARD) | |||
| endif() | |||
|
|
|||
| if(NOT CMAKE_CXX_STANDARD) | |||
| set(CMAKE_CXX_STANDARD 11) | |||
| set(CMAKE_CXX_STANDARD 17) | |||
There was a problem hiding this comment.
My thoughts:
- Could this be limited to yocto? I think we're targeting to make OTBR work on C++11.
- Could we specify an older version of protobuf version so it doesn't have to depend on
std::string_view? cc @morningboata
There was a problem hiding this comment.
Currently the protobuf is install by the system's libprotobuf-dev and protobuf-compiler library. It's hard to config the custom proto generator & library, and change the CMAKER's default proto generator & library MACROs. I don't know what is the proper way yet. It's better that the OS can install an older version of libprotobuf-dev and protobuf-compiler library, and CMAKER detects that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Yocto 5.0 protobuf version as been updated and requires to link the absl which requires minimum C++14.
/include/absl/base/policy_checks.h:79:2: error: #error "C++ versions less than C++14 are not supported." | 79 | #error "C++ versions less than C++14 are not supported." | | ^~~~~ | compilation terminated due to -Wfatal-errors.and absl uses strings/string_view which is supported from c++17
include/absl/strings/string_view.h:53:26: error: 'string_view' in namespace 'std' does not name a type | 53 | using string_view = std::string_view; | | ^~~~~~~~~~~ | compilation terminated due to -Wfatal-errors.