Add KUTTL make targets for telemetry #606

paramite · 2023-10-26T13:03:48Z

Depends-On: openstack-k8s-operators/telemetry-operator#213

openshift-ci · 2023-10-26T13:04:00Z

Hi @paramite. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

softwarefactory-project-zuul · 2023-10-26T14:47:15Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b093dd5080fa4ff28b0b4442c1b635b1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 47s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 59m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 01m 35s
❌ data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 15m 47s

paramite · 2023-10-26T15:30:12Z

recheck

softwarefactory-project-zuul · 2023-10-26T17:15:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1c19149ee1784338a173bde97fa1a6b5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 40s
❌ install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 33s
❌ data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 20m 04s

paramite · 2023-10-26T18:22:04Z

recheck

softwarefactory-project-zuul · 2023-10-26T19:53:07Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f4f6207e0e544528acf98a00df5d01d0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 51s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 56m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 02m 35s
❌ data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 14m 57s

paramite · 2023-10-27T07:45:51Z

recheck

softwarefactory-project-zuul · 2023-10-27T09:19:10Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/69dd038e7c674c3c81f4e0be1ec2ff8e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 31m 44s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 04m 37s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 06m 56s
❌ data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 14m 46s

paramite · 2023-10-27T19:43:35Z

recheck

softwarefactory-project-zuul · 2023-10-27T21:16:48Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5f58d8135c6c4791912a65073102c3eb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 55s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 58m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 02m 25s
❌ data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 14m 02s

abays · 2023-10-30T11:56:13Z

/ok-to-test

abays · 2023-10-30T11:56:34Z

recheck

softwarefactory-project-zuul · 2023-10-30T13:33:40Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9b91057dee764ca5a539a9f611a0d307

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 40s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 58m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 59m 06s
❌ data-plane-adoption-github-rdo-centos-9-crc-single-node FAILURE in 1h 19m 18s

cescgina · 2023-10-30T15:22:33Z

The data-plane-adoption-github-rdo-centos-9-crc-single-node failure is known and a fix is on the way. Plus, it's not related to the patch, so feel free to ignore it.

abays · 2023-10-30T15:29:11Z

/override data-plane-adoption-github-rdo-centos-9-crc-single-node

openshift-ci · 2023-10-30T15:29:15Z

@abays: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

data-plane-adoption-github-rdo-centos-9-crc-single-node

Only the following failed contexts/checkruns were expected:

ci/prow/images
ci/prow/install-yamls-deploy
ci/prow/precommit-check
pull-ci-openstack-k8s-operators-install_yamls-main-images
pull-ci-openstack-k8s-operators-install_yamls-main-install-yamls-deploy
pull-ci-openstack-k8s-operators-install_yamls-main-precommit-check
rdoproject.org/github-check
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override data-plane-adoption-github-rdo-centos-9-crc-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abays · 2023-10-30T15:29:41Z

/override rdoproject.org/github-check

openshift-ci · 2023-10-30T15:29:54Z

@abays: Overrode contexts on behalf of abays: rdoproject.org/github-check

In response to this:

/override rdoproject.org/github-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abays · 2023-10-30T15:37:04Z

Makefile

+telemetry_kuttl: export NAMESPACE = ${TELEMETRY_KUTTL_NAMESPACE}
+# Set the value of $TELEMETRY_KUTTL_NAMESPACE if you want to run the telemetry
+# kuttl tests in a namespace different than the default (telemetry-kuttl-tests)
+telemetry_kuttl: input deploy_cleanup telemetry telemetry_deploy_prep


If Telemetry operator depends on other operators (such as MariaDB, Keystone, etc), then you'll need to address those dependencies here as pre-targets. i.e. kuttl_common_prep. For example [1].

[1]

install_yamls/Makefile

Line 1611 in c0a3767

manila_kuttl: kuttl_common_prep ceph manila manila_deploy_prep ## runs kuttl tests for manila operator. Installs manila operator and cleans up previous deployments before and after running the tests.

Makefile

cescgina

I tried running the tests, but while it finds the autoscaling test suite, it does not run any tests because the test files are inside a test folder, but kuttl expects them inside autoscaling. So, path/tests/suites/autoscaling/01-assert.yaml instead of path/tests/suites/autoscaling/tests/01-assert.yaml

paramite · 2023-10-31T10:48:51Z

Thanks for hints. Fixed dependencies (added kuttl_common_prep and heat) and added testDirs to config, because telemetry-operator gonna have more than one test suite.

paramite · 2023-10-31T17:34:48Z

Currently tests work, just timeouts too early during Prometheus init. Patch in operator [1] is already submitted.

[1] openstack-k8s-operators/telemetry-operator#221

cescgina

Changes lgtm, however I could not get the tests to pass unless the namespace fields in the assert file was removed. Looks like the assert is expecting the resources to be deployed in a namespace called telemetry-kuttl-autoscaling, apply this commit the tests passed for me: cescgina/telemetry-operator@a2d693c

paramite · 2023-11-01T11:57:02Z

Ah, that's good point. Thanks for that. Do you mind submitting PR with this?

cescgina · 2023-11-01T12:01:06Z

Ah, that's good point. Thanks for that. Do you mind submitting PR with this?

Sure, I opened openstack-k8s-operators/telemetry-operator#222

paramite · 2023-11-02T08:48:49Z

Your PR is merged. So what now? Do I need to do something else with this PR?

cescgina · 2023-11-02T08:50:43Z

Your PR is merged. So what now? Do I need to do something else with this PR?

PR lgtm, IMO it can be merged now, but I don't have approver rights, @abays can you take a look when free?

vyzigold · 2023-11-13T07:37:03Z

/lgtm

fao89 · 2023-11-14T07:57:43Z

/approve

openshift-ci · 2023-11-14T07:57:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, paramite

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fao89]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from slagle and stuggi October 26, 2023 13:03

openshift-ci bot added the needs-ok-to-test label Oct 26, 2023

openshift-ci bot added ok-to-test and removed needs-ok-to-test labels Oct 30, 2023

abays reviewed Oct 30, 2023

View reviewed changes

cescgina reviewed Oct 30, 2023

View reviewed changes

Makefile Show resolved Hide resolved

cescgina reviewed Oct 30, 2023

View reviewed changes

paramite force-pushed the tlmtr-kuttl-autoscaling branch from 0795a7c to 509b5f5 Compare October 31, 2023 10:46

Add KUTTL make targets for telemetry

dd2f3b8

paramite force-pushed the tlmtr-kuttl-autoscaling branch from 509b5f5 to dd2f3b8 Compare October 31, 2023 17:24

paramite closed this Nov 1, 2023

paramite reopened this Nov 1, 2023

cescgina reviewed Nov 1, 2023

View reviewed changes

paramite mentioned this pull request Nov 10, 2023

Add KUTTL job execution for openstack-k8s-operators/telemetry-operator openshift/release#45552

Merged

openshift-ci bot assigned vyzigold Nov 13, 2023

openshift-ci bot added the lgtm label Nov 13, 2023

openshift-ci bot added the approved label Nov 14, 2023

openshift-merge-bot bot merged commit 7e246cf into openstack-k8s-operators:main Nov 14, 2023
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add KUTTL make targets for telemetry #606

Add KUTTL make targets for telemetry #606

paramite commented Oct 26, 2023

openshift-ci bot commented Oct 26, 2023

softwarefactory-project-zuul bot commented Oct 26, 2023

paramite commented Oct 26, 2023

softwarefactory-project-zuul bot commented Oct 26, 2023

paramite commented Oct 26, 2023

softwarefactory-project-zuul bot commented Oct 26, 2023

paramite commented Oct 27, 2023

softwarefactory-project-zuul bot commented Oct 27, 2023

paramite commented Oct 27, 2023

softwarefactory-project-zuul bot commented Oct 27, 2023

abays commented Oct 30, 2023

abays commented Oct 30, 2023

softwarefactory-project-zuul bot commented Oct 30, 2023

cescgina commented Oct 30, 2023

abays commented Oct 30, 2023

openshift-ci bot commented Oct 30, 2023

abays commented Oct 30, 2023

openshift-ci bot commented Oct 30, 2023

abays Oct 30, 2023

cescgina left a comment

paramite commented Oct 31, 2023

paramite commented Oct 31, 2023 •

edited

Loading

cescgina left a comment

paramite commented Nov 1, 2023

cescgina commented Nov 1, 2023

paramite commented Nov 2, 2023

cescgina commented Nov 2, 2023

vyzigold commented Nov 13, 2023

fao89 commented Nov 14, 2023

openshift-ci bot commented Nov 14, 2023

Add KUTTL make targets for telemetry #606

Add KUTTL make targets for telemetry #606

Conversation

paramite commented Oct 26, 2023

openshift-ci bot commented Oct 26, 2023

softwarefactory-project-zuul bot commented Oct 26, 2023

paramite commented Oct 26, 2023

softwarefactory-project-zuul bot commented Oct 26, 2023

paramite commented Oct 26, 2023

softwarefactory-project-zuul bot commented Oct 26, 2023

paramite commented Oct 27, 2023

softwarefactory-project-zuul bot commented Oct 27, 2023

paramite commented Oct 27, 2023

softwarefactory-project-zuul bot commented Oct 27, 2023

abays commented Oct 30, 2023

abays commented Oct 30, 2023

softwarefactory-project-zuul bot commented Oct 30, 2023

cescgina commented Oct 30, 2023

abays commented Oct 30, 2023

openshift-ci bot commented Oct 30, 2023

abays commented Oct 30, 2023

openshift-ci bot commented Oct 30, 2023

abays Oct 30, 2023

Choose a reason for hiding this comment

cescgina left a comment

Choose a reason for hiding this comment

paramite commented Oct 31, 2023

paramite commented Oct 31, 2023 • edited Loading

cescgina left a comment

Choose a reason for hiding this comment

paramite commented Nov 1, 2023

cescgina commented Nov 1, 2023

paramite commented Nov 2, 2023

cescgina commented Nov 2, 2023

vyzigold commented Nov 13, 2023

fao89 commented Nov 14, 2023

openshift-ci bot commented Nov 14, 2023

paramite commented Oct 31, 2023 •

edited

Loading