Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 1500 MTU consistently #444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdatko
Copy link
Contributor

@sdatko sdatko commented Nov 13, 2024

We were having mixed values in some scenarios, in some places specifying 9000 while in fact 1500 value was used in the deployed infrastructure. This commit changes it consistently for all uni jobs to stick with default 1500 MTU.

Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdatko
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 13, 2024

Hi @sdatko. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

We were having mixed values in some scenarios,
in some places specifying 9000 while in fact
1500 value was used in the deployed infrastructure.
This commit changes it consistently for all uni jobs
to stick with default 1500 MTU.
@fultonj
Copy link
Contributor

fultonj commented Nov 14, 2024

I don't like this change because...

The storage and storage_mgmt network benefit from having MTU 9000 with Ceph. You would not deploy Ceph without setting the MTU to 9000. Any VA/DT which uses Ceph should have this or it's less realistic.

Because in our deployment the Storage and Storage Mgmt network are VLANs trunked from control plane, control plane also needs to be MTU 9000 if we want Storage and Storage Mgmt to use MTU 9000.

@sdatko
Copy link
Contributor Author

sdatko commented Nov 14, 2024

The storage and storage_mgmt network benefit from having MTU 9000 with Ceph. You would not deploy Ceph without setting the MTU to 9000. Any VA/DT which uses Ceph should have this or it's less realistic.

So, uni01alpha, uni02beta, uni06zeta and uni07eta do not involve Ceph.

Because in our deployment the Storage and Storage Mgmt network are VLANs trunked from control plane, control plane also needs to be MTU 9000 if we want Storage and Storage Mgmt to use MTU 9000.

In uni05epsilon we did not set MTU 9000 before and in uni04delta it was specified here, but not actually used I think (at least according to my quick check, I did not see 9000 in any network interface, but I may be wrong); the same was for uni03gamma (VA/HCI).

@fultonj
Copy link
Contributor

fultonj commented Nov 15, 2024

The storage and storage_mgmt network benefit from having MTU 9000 with Ceph. You would not deploy Ceph without setting the MTU to 9000. Any VA/DT which uses Ceph should have this or it's less realistic.

So, uni01alpha, uni02beta, uni06zeta and uni07eta do not involve Ceph.

I agree and I have no problem with them having the 1500 MTU.

Because in our deployment the Storage and Storage Mgmt network are VLANs trunked from control plane, control plane also needs to be MTU 9000 if we want Storage and Storage Mgmt to use MTU 9000.

In uni05epsilon we did not set MTU 9000 before and in uni04delta it was specified here, but not actually used I think (at least according to my quick check, I did not see 9000 in any network interface, but I may be wrong); the same was for uni03gamma (VA/HCI).

Do you want to remove your changes to the following from this patch?

examples/va/hci/edpm-pre-ceph/nodeset/values.yaml
examples/va/hci/control-plane/nncp/values.yaml

so that your change only affects items in the dt directory?

@abays
Copy link
Contributor

abays commented Nov 18, 2024

The storage and storage_mgmt network benefit from having MTU 9000 with Ceph. You would not deploy Ceph without setting the MTU to 9000. Any VA/DT which uses Ceph should have this or it's less realistic.

So, uni01alpha, uni02beta, uni06zeta and uni07eta do not involve Ceph.

I agree and I have no problem with them having the 1500 MTU.

Because in our deployment the Storage and Storage Mgmt network are VLANs trunked from control plane, control plane also needs to be MTU 9000 if we want Storage and Storage Mgmt to use MTU 9000.

In uni05epsilon we did not set MTU 9000 before and in uni04delta it was specified here, but not actually used I think (at least according to my quick check, I did not see 9000 in any network interface, but I may be wrong); the same was for uni03gamma (VA/HCI).

Do you want to remove your changes to the following from this patch?

examples/va/hci/edpm-pre-ceph/nodeset/values.yaml examples/va/hci/control-plane/nncp/values.yaml

so that your change only affects items in the dt directory?

I think this suggestion makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants