-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to 1500 MTU consistently #444
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdatko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @sdatko. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We were having mixed values in some scenarios, in some places specifying 9000 while in fact 1500 value was used in the deployed infrastructure. This commit changes it consistently for all uni jobs to stick with default 1500 MTU.
I don't like this change because... The storage and storage_mgmt network benefit from having MTU 9000 with Ceph. You would not deploy Ceph without setting the MTU to 9000. Any VA/DT which uses Ceph should have this or it's less realistic. Because in our deployment the Storage and Storage Mgmt network are VLANs trunked from control plane, control plane also needs to be MTU 9000 if we want Storage and Storage Mgmt to use MTU 9000. |
So, uni01alpha, uni02beta, uni06zeta and uni07eta do not involve Ceph.
In uni05epsilon we did not set MTU 9000 before and in uni04delta it was specified here, but not actually used I think (at least according to my quick check, I did not see 9000 in any network interface, but I may be wrong); the same was for uni03gamma (VA/HCI). |
I agree and I have no problem with them having the 1500 MTU.
Do you want to remove your changes to the following from this patch? examples/va/hci/edpm-pre-ceph/nodeset/values.yaml so that your change only affects items in the |
I think this suggestion makes sense. |
We were having mixed values in some scenarios, in some places specifying 9000 while in fact 1500 value was used in the deployed infrastructure. This commit changes it consistently for all uni jobs to stick with default 1500 MTU.