Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT - BMO deploy with preprovisioningNetworkData #413

Merged

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Oct 4, 2024

This DT ...

  • Uses OCP Metal3 to provision the compute nodes over redfish-virtualmedia.
  • Deploys the two pairs of compute nodes in separate networks - routed/spine-and-leaf architecture.

Depends-On: openstack-k8s-operators/ci-framework#2425

Copy link
Contributor

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2425 is needed.

openshift-merge-bot bot pushed a commit to openstack-k8s-operators/ci-framework that referenced this pull request Oct 18, 2024
This adds ci_gen_kustomize_values for the proposed `bmo01` deployment
topology in openstack-k8s-operators/architecture PR:
openstack-k8s-operators/architecture#413

This DT ...
* Uses OCP Metal3 to provision the compute nodes over redfish-virtualmedia.
* Deploys the two pairs of compute nodes in separate networks -
  routed/spine-and-leaf architecture.
@hjensas hjensas force-pushed the bmo01 branch 7 times, most recently from e0d980e to 26aa0fc Compare October 24, 2024 22:14
@hjensas hjensas force-pushed the bmo01 branch 2 times, most recently from 380896f to b4e6bed Compare October 28, 2024 09:42
Comment on lines 15 to 18
Change to the uni01alpha directory

```bash
cd architecture/examples/dt/bmo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Change to the uni01alpha directory
```bash
cd architecture/examples/dt/bmo
Change to the bmo01 directory
```bash
cd architecture/examples/dt/bmo01

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!
Done.

Comment on lines 15 to 18
Change to the dataplane directory

```bash
cd architecture/examples/dt/bmo/dataplane
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Change to the dataplane directory
```bash
cd architecture/examples/dt/bmo/dataplane
Change to the dataplane directory
```bash
cd architecture/examples/dt/bmo01/dataplane

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!
Done.

Comment on lines 62 to 65
leaf0-0 inspecting false 53s
leaf0-1 inspecting false 53s
leaf1-0 inspecting false 53s
leaf1-1 inspecting false 53s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should show this, since we are disabling inspection by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's drop it. I cleaned it up a little so it is just one line of preparing and available for each node as well.

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple docs comments but otherwise seems good to me

@hjensas hjensas force-pushed the bmo01 branch 2 times, most recently from 7023bf7 to c40ab96 Compare October 28, 2024 18:09
@pablintino
Copy link
Contributor

Thanks for the update @hjensas. I'm fine
/lgtm

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, hjensas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/976f3e4174b1450eb7fe91896c6c1cb3

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bmo01 SUCCESS in 3m 45s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 652e706 into openstack-k8s-operators:main Oct 29, 2024
9 checks passed
drosenfe pushed a commit to drosenfe/ci-framework that referenced this pull request Nov 13, 2024
This adds ci_gen_kustomize_values for the proposed `bmo01` deployment
topology in openstack-k8s-operators/architecture PR:
openstack-k8s-operators/architecture#413

This DT ...
* Uses OCP Metal3 to provision the compute nodes over redfish-virtualmedia.
* Deploys the two pairs of compute nodes in separate networks -
  routed/spine-and-leaf architecture.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants